Redact auth in wheel cache origin warnings - #14233
Open
carrerasdarren-cell wants to merge 1 commit into
Open
Conversation
sbidoul
reviewed
Aug 9, 2026
sbidoul
left a comment
sbidoul
left a comment
Member
There was a problem hiding this comment.
Looks generally good. A couple of minor remarks.
| # TODO: use DirectUrl.equivalent when | ||
| # https://github.com/pypa/pip/pull/10564 is merged. | ||
| if origin.url != download_info.url: | ||
| origin_url = origin.to_dict_compat()["url"] |
Member
There was a problem hiding this comment.
Is this necessary, since origin comes from an already serialized source, which is already stripped)?
| @staticmethod | ||
| def record_download_origin(cache_dir: str, download_info: DirectUrl) -> None: | ||
| origin_path = Path(cache_dir) / ORIGIN_JSON_NAME | ||
| download_url = download_info.to_dict_compat()["url"] |
Member
There was a problem hiding this comment.
This can be moved just before the test since computing it is not necessary if origin_path does not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14232.
record_download_origin()writes a credential-stripped PEP 610 URL toorigin.json, but previously compared and logged the raw in-memory URL. Re-recording an authenticated origin therefore produced a false mismatch warning containing the username and password.This change compares the same serialized URL representation that is written to disk and uses those stripped values in genuine mismatch warnings. It adds regression coverage for both behaviors.
PR Checklist:
Assisted-by: OpenAI Codex
Tests
pytest -q tests/unit/test_cache.py: 10 passedgit diff --checkpassed